Pull Requests and Code Review process

Posted on
  • I have noticed that pull requests now get reviewed by various people.
    I think this is a good thing - hopefully it will lead to higher quality code, better consistancy.

    Who are the reviewers, can anyone review ?

    Did I miss some announcements ?

    Do we have a check list of things ? For example I feel screenshots should be mandatory. I hate having to install an app in order to see what it looks like, only to decide I dont like it and delete it, when I could have decided that from a screenshot. For example the Orloj clock looked intresting, but I could not understand what it would be like from the description. The screenshot below would have told me what I needed to know at a glance.

    1 Attachment

    • download.png
  • I'm one of the recently added reviewers :)

    Here's an issue on the BangleApps repo regarding maintainers: https://github.com/espruino/BangleApps/i­ssues/2993

    And a checklist for maintainers and contributors on app contributions: https://github.com/espruino/BangleApps/w­iki/App-Contribution

    In that last link you'll find the current stance about screenshots, they're a 'nice to have' for now. It's a balance not making too many demands as to not overwhelm new contributors, is the reasoning I think.

  • Post a reply
    • Bold
    • Italics
    • Link
    • Image
    • List
    • Quote
    • code
    • Preview

Pull Requests and Code Review process

Posted by Avatar for HughB @HughB