Potential issue with v2.12.114

Hi @Gordon

I was contacted by a user saying the Daisy and Circle clock no longer worked after upgrading to 2v.12.114.

I first checked Daisy works fine on v2.12 and on v2.12.101.
After upgrading to v2.12.114 I get the following on the console when starting Daisy.

 2v12.114 (c) 2021 G.Williams
Uncaught Error: Function "\x19\0\0\0ontBloggerSansLight46" not found!
 at line 27 col 19 in daisy.app.js
g.setFontBloggerSansLight46(1);
  ^
in function "setLargeFont" called from line 47 col 330 in daisy.app.js
...p_steps),0,0);setLargeFont();g.setColor(settings.fg);g.setFo...
                              ^
in function "drawClock" called from line 46 col 27 in daisy.app.js
if(!idle)drawClock();else drawIdle();queueDraw();
                       ^
in function "draw" called from line 74 col 6 in daisy.app.js
draw();
     ^
>

The user also reported that Circles clock (not one of my clocks) also broke with 2.12.144.
In the console I now get:

 2v12.114 (c) 2021 G.Williams
Uncaught ReferenceError: "drawInnerCircleAndTriangle" is not defined
 at line 55 col 335 in circlesclock.app.js
...Gauge(w,h3,percent,color);}drawInnerCircleAndTriangle(w);wri...
                              ^
in function "drawHeartRate" called from line 76 col 99 in circlesclock.app.js
...tValue='...';drawHeartRate();}
                              ^
in function "enableHRMSensor" called from line 84 col 42 in circlesclock.app.js
if(isCircleEnabled("hr")){enableHRMSensor();}

On reverting to v2.12 again both clocks work without issue.

Something broken in v2.12.114 ?

I think this might be related to the problem reported in this thread: My GPS Run App called Race
. My hunch is that JS function names above a certain length are causing issues...

As the firmware is written in C it is possibly a buffer overrun. Looks like memory corruption to me.

ot sure if related, but since the upgrade to v2.12.114, contours clock only shows a blank screen, but widgets.
Back to other clocks works fine (Sonic, Dub)

Thanks - I'll look into it now. It may well be related to this change which came in for v2.12.114: https://github.com/espruino/Espruino/commit/3cc43cde8c89fd68810a3d34930c79b3cecbbe49

Ok, it's fixed in 2.12.115 now - it seems I couldn't easily reproduce it in the desktop build

thank you !