modularizing BangleJS

You are reading a single comment by @Ganblejs and its replies. Click here to read the full conversation.

•

Gordon

Thanks! Yes, this looks good - although I guess if it were possible to just treat the Emscripten build just like another type of hardware (eg a _impl file with empty functions) I think that might be preferable? After all the point of this is really to try and avoid special-case stuff as much as possible.

It'd be great if others could take a look at this and let me know what they think though

Given this is going to end up being a big change that will affect anyone who works on the Bangle.js codebase, it would be good to have more than just me and @fanoush looking at it

•

Ganblejs in reply to @Gordon

a big change that will affect anyone who works on the Bangle.js codebase,

Even me who mostly stay in the espruino/BangleApps repo?

•

user156811 in reply to @Ganblejs

As long as it doesn't add any new bugs it shouldn't effect the BangleApps repo.

The code suggestion i'm putting forward are to basically separate out the hardware into there own modules in the bangleJS library. Then from there separate out how each piece of hardware works.

About

Avatar for Ganblejs @Ganblejs started