I have noticed that pull requests now get reviewed by various people.
I think this is a good thing - hopefully it will lead to higher quality code, better consistancy.
Who are the reviewers, can anyone review ?
Did I miss some announcements ?
Do we have a check list of things ? For example I feel screenshots should be mandatory. I hate having to install an app in order to see what it looks like, only to decide I dont like it and delete it, when I could have decided that from a screenshot. For example the Orloj clock looked intresting, but I could not understand what it would be like from the description. The screenshot below would have told me what I needed to know at a glance.
Espruino is a JavaScript interpreter for low-power Microcontrollers. This site is both a support community for Espruino and a place to share what you are working on.
I have noticed that pull requests now get reviewed by various people.
I think this is a good thing - hopefully it will lead to higher quality code, better consistancy.
Who are the reviewers, can anyone review ?
Did I miss some announcements ?
Do we have a check list of things ? For example I feel screenshots should be mandatory. I hate having to install an app in order to see what it looks like, only to decide I dont like it and delete it, when I could have decided that from a screenshot. For example the
Orloj
clock looked intresting, but I could not understand what it would be like from the description. The screenshot below would have told me what I needed to know at a glance.1 Attachment