Icon Laucher, fullscreen setting, what is expected behaviour with fast clocks

You are reading a single comment by @Gordon and its replies. Click here to read the full conversation.

•

Gordon

On the other hand, if we set widget_utils.show() in the remove- function and fast load a clock that should be full screen it will get widgets if it itself doesn't tell widgets to hide.

That's correct. Clocks that don't use loadWidgets automatically don't get fast-loaded. If they have loadWidgets and they don't want widgets then they should hide them.

So I think IconLauncher should hide widgets as suggested - I've just done that

Maybe apps that utilize fast loading (clocks and launchers so far) should be expected to tell widgets to either .hide(), .show() or use .swipeOn()?

Yes, they should if they have a loadWidgets call but they don't want widgets showing.

I do mention that fast loaded apps need widgets in https://www.espruino.com/Bangle.js+Fast+Load but if you think this could be clearer, PRs alwayts welcome :)

•

Ganblejs in reply to @Gordon

I do mention that fast loaded apps need widgets in https://www.espruino.com/Bangle.js+Fast+Load but if you think this could be clearer, PRs alwayts welcome :)

No, I don't think it's unclear that widgets need to be loaded. I didn't think the logic through. I guess there shouldn't be a case where setting .show() in the remove-function would lead to full screen clocks showing widgets.

But yes, I might to a PR regarding resetting widgets .show()-ing, .hide()-ing or .swipeOn()-ing in the remove-function. I'm debating whether to suggest saying to set .show() or .swipeOn(), since showing loaded widgets has been standard practice and is still kind of default if widget_utils isn't used, but .swipeOn() is the new recommended way.

Issue #2192 ties into this also.

We can discuss further when I make the PR.

About

Avatar for Gordon @Gordon started