-
• #2
Yes, what you've done there is exactly right - that's how you'd propose a change.
In that case I think there may be some issues with the code you're proposing, but I'll reply to that on github.
-
• #3
I am not sure understand, you say Bangle kill app when the screen is off ?
In my case, i just shut down compass when screen is off.
And i have found a bug, on the interval that call "reading" method.
An interval can be triggered several times without stopping the previous interval.
So it is impossible to stop the previous loops. -
• #4
I think I was confused because I saw:
Bangle.on('kill',()=>{Bangle.setCompassPower(0);});
And assumed this was something you added, but I think that was there before? The code there isn't needed and I have just removed it
-
• #5
Oh yes that was there before !
Thanks for review and for your times.
Good day !
Hello,
I was wondering if there was a process to propose a new update for an app that we did not create?
For example, I want to update the 'arrow' app, to disable compass when the screen off. (https://github.com/espruino/BangleApps/pull/856)
Thanks for your time, and sorry for my english.
Victor