Wow, thank you - that's awesome! Especially given your previous donations as well!
Thanks for everyone's help in tracking this down too. It's one of those nice cases where having Espruino on more platforms means more bugs get found and it gets more reliable for everyone.
Just FYI, the bug/fix is on https://github.com/espruino/Espruino/issues/1510 - in the end I went with just changing the call to jsvReadConfigObject to point to ints and copying them (as it seems that's what I'd done in other places).
As you suggested, JSV_CHAR would be a nicer idea, but we're using enums from the main interpreter where there isn't such a thing as a char. I guess it might make more sense to move to having a different set of enums for jsvConfigObject - it'd probably help to catch issues at compile-time too.
Espruino is a JavaScript interpreter for low-power Microcontrollers. This site is both a support community for Espruino and a place to share what you are working on.
Wow, thank you - that's awesome! Especially given your previous donations as well!
Thanks for everyone's help in tracking this down too. It's one of those nice cases where having Espruino on more platforms means more bugs get found and it gets more reliable for everyone.
Just FYI, the bug/fix is on https://github.com/espruino/Espruino/issues/1510 - in the end I went with just changing the call to
jsvReadConfigObject
to point to ints and copying them (as it seems that's what I'd done in other places).As you suggested,
JSV_CHAR
would be a nicer idea, but we're using enums from the main interpreter where there isn't such a thing as a char. I guess it might make more sense to move to having a different set of enums forjsvConfigObject
- it'd probably help to catch issues at compile-time too.