I have no idea how that code could ever work. I can't find any information on that function it's calling either - I suspect it's jumping through a lot of unnecessary hoops there, nor to % being valid in a variable name. Also, in any event, the % functions aren't defined anywhere. I wonder if they're calling out to things only available in V8?
Also, wtf@ %NewString?
It looks like they're making fixed length "strings" and loading them using those setchar functions.... Why are they doing it that way, though? For optimization?
I think that section ought to be totally reimplemented - all the code does is URL encode something (you know how spaces get turned into %20 in URLs - that); It could be a lot smaller than that, I think, particularly since we know the string is 8-bit.
© Espruino, powered by microcosm.
Report a problem