Posted at 2023-01-20 by Fteacher

The whole code doesn't fit in the post because of the pics. I'm going to attach the whole code to this post (I modified to .odt, so that there's no security issue with posting it). Still, the end of the code (after the pictures) is here:

g.setFont("Vector",20);
//Subdivided zones for better readability of zones when calling the background images. //Changing HR zones will trigger the change of the background image and the HR to change zone.

if (hr <= minhr) {
  console.log("HR too low");
} else if (hr <= hrr*0.6 + minhr) {
  g.drawImage(getzone1(),0,0,{scale:1.2});g.drawString("Z1", 32,78);g.drawString(minzone2, 62,20);
} else if (hr <= hrr*0.64 + minhr) {
  g.drawImage(getzone2a(),0,0,{scale:1.2});g.drawString("Z2", 32,78);g.drawString(maxzone2, 62,20);g.drawString(minzone2, 62,136);
} else if (hr <= hrr*0.67+minhr) {
  g.drawImage(getzone2b(),0,0,{scale:1.2});g.drawString("Z2", 32,78);g.drawString(maxzone2, 62,20);g.drawString(minzone2, 62,136);
} else if (hr <= hrr * 0.7 + minhr) {
 g.drawImage(getzone2c(),0,0,{scale:1.2});g.drawString("Z2", 32,78);g.drawString(maxzone2, 62,20);g.drawString(minzone2, 62,136);
} else if (hr <= hrr * 0.74 + minhr) {
  g.drawImage(getzone3a(),0,0,{scale:1.2});g.drawString("Z3", 32,78);g.drawString(maxzone3, 62,20);g.drawString(maxzone2, 62,136);
} else if (hr <= hrr * 0.77 + minhr) {
  g.drawImage(getzone3b(),0,0,{scale:1.2});g.drawString("Z3", 32,78);g.drawString(maxzone3, 62,20);g.drawString(maxzone2, 62,136);
} else if (hr <= hrr * 0.8 + minhr) {
  g.drawImage(getzone3c(),0,0,{scale:1.2});g.drawString("Z3", 32,78);g.drawString(maxzone3, 62,20);g.drawString(maxzone2, 62,136);
} else if (hr <= hrr * 0.84 + minhr) {
  g.drawImage(getzone4a(),0,0,{scale:1.2});g.drawString("Z4", 32,78);g.drawString(maxzone4, 62,20);g.drawString(maxzone3, 62,136);
} else if (hr <= hrr * 0.87 + minhr) {
  g.drawImage(getzone4b(),0,0,{scale:1.2});g.drawString("Z4", 32,78);g.drawString(maxzone4, 62,20);g.drawString(maxzone3, 62,136);
} else if (hr <= hrr * 0.9 + minhr) {
  g.drawImage(getzone4c(),0,0,{scale:1.2});g.drawString("Z4", 32,78);g.drawString(maxzone4, 62,20);g.drawString(maxzone3, 62,136);
} else if (hr <= hrr * 0.94 + minhr) {
  g.drawImage(getzone5a(),0,0,{scale:1.2});g.drawString("Z5", 32,78);g.drawString(maxzone5, 62,20);g.drawString(maxzone4, 62,136);
} else if (hr <= hrr * 0.96 + minhr) {
  g.drawImage(getzone5b(),0,0,{scale:1.2});g.drawString("Z5", 32,78);g.drawString(maxzone5, 62,20);g.drawString(maxzone4, 62,136);
} else if (hr <= hrr * 0.98 + minhr) {
  g.drawImage(getzone5c(),0,0,{scale:1.2});g.drawString("Z5", 32,78);g.drawString(maxzone5, 62,20);g.drawString(maxzone4, 62,136);
} else if (hr >= maxhr - 2) {
  g.clear();g.drawImage(getzonealert(),0,0,{scale:1.2});g.setFont("Vector",38);g.drawString("ALERT", 20,53);g.drawString("HR limit", 18,84);
}

Attachments:

• run+.app.js.odt

Posted at 2023-01-20 by user140377

ok, I think we should concentrate on the swipe switch layout thing first to get your code on github as soon as possible. It is better readable there.

These are the first steps I recommend:

1. Read http://www.espruino.com/Bangle.js+App+Loader on how to fork and locally checkout the Bangle Repository.
2. Place your code in a file inside apps/run/ in a file named for example karvonnen.js and upload it to github.

Once this is done we can add http://www.espruino.com/Reference#l_Bangle_swipe to listen to swipes to switch layout.

Posted at 2023-01-20 by @gfwilliams

That looks great! One thing I'd say is maybe rather than using images, you could just draw the individual zones as polygons. There's no function built in but it's easy enough to do. For instance:

const R = Bangle.appRect, CX = R.x+R.w/2, CY = R.y+R.h/2, CR = (R.h/2)-8;

g.drawSlice = function(pa, pb, size) {
  pa = (pa+0.05)*Math.PI/8;
  pb = (pb-0.05)*Math.PI/8;
  let a = (pb-pa)/6.01;
  let poly = [CX,CY], ir = CR-size;
  for (let r = pa; r <= pb; r += a) {
    poly.unshift(
      CX + ir * Math.sin(r),
      CY - ir * Math.cos(r)
    );
    poly.push(
      CX + CR * Math.sin(r),
      CY - CR * Math.cos(r)
    );
  }
  return this.fillPoly(poly);
}

g.clear();

// top 2 big slices
g.setColor(E.HSBtoRGB(0,1,1,16)).drawSlice(0,2, 10);
g.setColor(E.HSBtoRGB(0.9,1,1,16)).drawSlice(14,16, 10);
// other slices
for (var i=2;i<14;i++) {
  g.setColor(E.HSBtoRGB(i/16,1,1,16)).drawSlice(i,i+1, 10+Math.pow(Math.random(),4)*20);

It'd likely be faster, would save a bunch of memory, and is a bit more flexible too as you can choose exactly how big and what color each slice is.

Attachments:

• ex_zones.png

Posted at 2023-01-21 by @halemmerich

This could also use fillArc() from graphics_utils lib for drawing the segments.

Posted at 2023-01-22 by Fteacher

Thanks a bunch guys ! Waow, that's incredible what you can do with code. Basically, I can decypher 20% of Gordon's code, the rest is like 3d hieroglyphs.
fillArc() seems closer to my abilities, but still, quite a huge gap to fill (starting with figuring out how sin, cos, radians work...)
It took me 4 days to write this code and do the graphics, which lead to running late on major projects (studies, moving interstate,...). I need 2 weeks to catch up, at least.
If you feel like finishing that thing, feel free to use the concept and the code I posted (if there's anything worth keeping).
If it's just me, I will just use the heavy weight code whenever I have time, as I can't do any better.
Still, thanks ! Now I see what code wizardry can do !

Posted at 2023-01-22 by @halemmerich

You can just use the library to draw an arc like this:

g.clear();
const GU = require("graphics_utils");
let centreX = 0.5 * g.getWidth();
let centreY = 0.5 * g.getWidth();
let startAngle = GU.degreesToRadians(20);
let endAngle = GU.degreesToRadians(135);
let minRadius = 0.3 * g.getWidth();
let maxRadius = 0.45 * g.getWidth();
GU.fillArc(g, centreX, centreY, minRadius, maxRadius, startAngle, endAngle);

Gordons code does very similar things by constructing a polygon that approximates the arc.

Attachments:

• arc.png

Posted at 2023-01-23 by @gfwilliams

I'd forgotten about require("graphics_utils"); - that'd be much easier! :)

Posted at 2023-02-13 by Fteacher

Hello guys,
my app is on github, finally: https://github.com/f-teacher/karvonnen . Feel free to do what's needed to have it run. You can reuse and publish, just make it work, please !

Posted at 2023-02-14 by Fteacher

Also, I tried to send Halemmerich's code in the watch and in the emulator with the same result: module graphics_utils not found. I don't know what I'm doing wrong there.

Posted at 2023-02-14 by @thyttan

Check this comment out :) Or more specifically this readme.

Posted at 2023-02-16 by Fteacher

Thank you @thyttan. Now that I've followed these instructions, I can make it work. I'm restarting the creative (but so tedious for beginners) process of coding.

Posted at 2023-02-16 by Fteacher

Ok, I've done something cleaner thanks to your comments :).
I'm now using the require("graphics_utils") , very efficient. I reduced the number of lines to 109 and I made the code a bit less repetitive thanks to some functions. It's definitively much faster. It's in Github.
I'm still up for advices or help. I checked the swipe and I don't get how the swipe would take me from the running run.js to karvonnen.js (or if I have to merge it in one app). Also the HR input and the settings menu are not done at all. Some improvements are needed on the new graphical layout, that's the most doable part for me.
Thanks again for your help and encouragement.

Posted at 2023-02-16 by @thyttan

I checked the swipe and I don't get how the swipe would take me from the running run.js to karvonnen.js (or if I have to merge it in one app).

With regards to separate files vs. merging in your code in run.app.js both approaches are doable. EDIT: But after considering your specification in the OP I think you should try to merge into one file.

I think it may be easiest to define a function handling swipe events in the run app, I usually call them swipeHandler, where you call load('karvonnen.js'). Then doing Bangle.on('swipe', swipeHandler) to make the Bangle listen for swipes and execute the function.

Check out the Espruino Hardware Reference for load(), event swipe, and maybe Bangle.setUI().

If you want to swipe between the regular run app and korvonnen frequently it's maybe better to implement it as one (or several) functions to call inside run.app.js. If you want the run app to work simultaneously as well this will probably be the way to go. EDIT: I believe this is what you want.

Posted at 2023-02-16 by @thyttan

Why do you want to implement it inside the run app? Wouldn't it be easier to make it a separate app? I think the functionality could stand on it's own when it's done.

That way you also get to practice the basics of creating the required metadata, settings.js and icons etc, utilizing the tutorials along the way :)

Posted at 2023-02-17 by Fteacher

I'm going to describe what I need. I usually run 50 to 80 minutes. I'm almost satisfied with the run app's live data (HR, duration, distance, avg speed) and being able to extract a gpx after the run is critical to keep track of my runs. Basically, the run app covers the performance and the Karvonnen would allow me to check the intensity of my effort. So I need the Karvonnen app for most of my run and the run app just a few times during the run to check how I'm doing in terms of performance. Also, as soon as I'm running faster (increasing the intensity), I struggle to read the small numbers of the run app, I needed something bigger. For my personnal use, I will add a buzz when changing HR zone. I definitively want to swipe between run and Karvonnen and have the benefits of both.
I'm very happy to learn coding and I'm glad I have help to know where to look to implement what I need. Still, I have little spare time for coding and the process is very long for me. It took me 10 hours to get this code running. Now that I think about it, I think I should have written it differently... I will restart the process in a few weeks.

Posted at 2023-02-17 by @thyttan

I definitively want to swipe between run and Karvonnen and have the benefits of both.

Ok!

I started merging the code here just to show how it can be done, it's not perfect in any way :) There are some intervals in the run app code that must be stopped (or modified, I don't really understand the code yet :P) and started again when switching UI, and there are significant ram leaks right now.

What works is swiping back and forth to display the different UI's.

EDIT: Can be installed via my app loader.

Posted at 2023-02-17 by @allObjects

@FTeacher, I like your comment

I'm restarting the creative (but so tedious for beginners) process of coding.

a lot, especially this part: ...so tedious for beginners

I can tell you that without Espruino / @gfwilliams's platform, you would not even find a word in the whole universe to describe it...

just saying.

Enjoy the creative writing process... Espruino likes to read your stories and follow them to the tee... so watch what you are asking it for!

Posted at 2023-02-18 by @halemmerich

Every useful line of code has dozens to hundreds deleted ones standing behind it ;)

Posted at 2023-02-18 by @thyttan

I have tweaked the merged code and it seems to work pretty well now! I am sure there are things that can be done better and bugs will be found. Some cleanup should be done as well. But I don't get large ram leaks at least, and the run app functionality runs in the background when the karvonnen UI is displayed. Use the links in my previous reply.

EDIT: I did a pull request into your master branch in case you want to continue with the karvonnen code accessible from app.js :)

Posted at 2023-02-19 by user140377

Good job, just one question: Wouldn't it be better to jeep the code in a separate file for a.) clarity and b.) Easier extensibility in case of an alternative "zone-method"?

oh another question, was this tested on Bangle 1 & 2?

Posted at 2023-02-19 by @thyttan

Wouldn't it be better to jeep the code in a separate file for a.) clarity and b.) Easier extensibility in case of an alternative "zone-method"?

I agree with both your points, I just didn't know how to achieve both having them run concurrently and have them in separate files. Maybe have them in different files on the app loader but require karvonnen into run.app.js when loading it to the clock? The Karvonnen code is pretty much intact so something like that could maybe work?

was this tested on Bangle 1 & 2?

Unfortunately no, only on my Bangle 2. I just checked ram usage, and it seems to be higher than before by a value of 100 across the different screens, with peak 3444 (27% of full RAM on Bangle 2) when the app asks to overwrite or start a new log.

EDIT: Could it be problematic somehow that I changed all 'var' declarations to 'let' declarations? I did it as part of tracking down RAM leaks, but don't know if it did any difference or not.

Posted at 2023-02-19 by user140377

Separation: I was aiming for something simple, like putting everything in karvonnen.js, adding this to metadata

    {
      "name": "runkarvonnen",
      "url": "karvonnen.js"
    },

and loading it in app.js:

function swipeHandler(LR,_) {
  if (LR==-1 && karvonnenActive && !isMenuDisplayed) run();
  if (LR==1 && !karvonnenActive && !isMenuDisplayed) require("runkarvonnen").karvonnen();
}

see attached run.diff.txt

Bangle.js 1: I have never used the run app, but if wanted I might be able to test later together with https://banglejs.com/apps/?id=sensortools as gps provider.

Attachments:

• run.diff.txt

Posted at 2023-02-19 by @thyttan

Thanks! I have done changes like you suggested and it works.

I used naming like for the modules (run_karvonnen.js and run_karvonnen), should I use the name you suggested instead as this is maybe not a module in the same sense as the ones in the module folder?

Use the same links as before. I rebased the code on my app loader on the PR to f-teacher:master.

Posted at 2023-02-19 by user140377

I'm not sure here (maybe this is for gordon?), for me at is ok as long as the name starts with "run" so in the storage the new file is sorted near all the other run files.

Posted at 2023-02-19 by Humpelstilzchen

I can't even run the version 0.14 on my Bangle.js 1. I get low memory error. I say we just remove it from the supported list for this app.

Posted at 2023-02-19 by @halemmerich

Maybe just give the run app a mechanism to eval additional pages which can be selected by swiping but are installed as separate apps. Just to keep run as slim as possible by default. An example for this would be the Recorder app. That searches for all files named *.recorder.js and evals those. The resulting objects are in an array and could just provide a draw method to be called if the page is swiped to.
I had a short run and I had two problems:

• The settings do not seem to have defaults, app crashes accessing the undefined settings object
• Swiping works fine, but the display was not updated but seemed complete otherwise

Posted at 2023-02-19 by @thyttan

Maybe just give the run app a mechanism to eval additional pages which can be selected by swiping but are installed as separate apps.

Sound like a good idea, it's beyond my current abilities though :P

The settings do not seem to have defaults, app crashes accessing the undefined settings object

Fixed this.

Swiping works fine, but the display was not updated but seemed complete otherwise

I've now seemingly got the ui to update as one would want. I tried to code it so it would only update the different elements when there is a relevant change, i.e. at least kind of lazily.

Usual caveats that there is sure to still be bugs and the code is maybe not the easiest to follow.. Use the same links as before.

Posted at 2023-02-20 by Fteacher

Hi all, and thanks for your participation in this !
It seems all this is going a long way :) !
Even though I have no time for this right now, I tried the app this morning and I could swipe, but reached a black screen each time I did so.
It seems the code was improved, I don't check it otherwise I'll get involved, dragged into it and carried away from critical tasks I have to complete.
I have no clue if it's the way to go, but I accepted the merge in github, I'll check it again when I'll try to catch up, but seemingly not before a week at least.

Posted at 2023-02-20 by @thyttan

Did some tweaks to behavior on button presses, I think it may now be ready for testing on actual runs, as before install it via my app loader.

Posted at 2023-02-20 by @halemmerich

I have tested a bit:

• Seems to work fine on dark theme, light theme needs dark fonts and light background arc for the zones.
• On my daily driver bangle the pulse number jumped to the top left and number stacked on each other. That must have been something other installed, on my other bangle that was not the case.
• I still get an error when there are no settings:

Uncaught Error: Cannot read property 'min' of undefined
 at line 3 col 292 in run_karvonnen
...or",20);}let minhr=hrmSettings.min;let maxhr=hrmSettings.max;function calc...
                                            ^
in function "show" called from line 38 col 216 in run.app.js
...(settings.HRM,exs.stats.bpm);}

Posted at 2023-02-20 by @thyttan

Thanks, shouldn't the HRM key added to line 23 below have taken care of missing hrm settings?

let settings = Object.assign({ 
   record: true, 
   B1: "dist", 
   B2: "time", 
   B3: "pacea", 
   B4: "bpm", 
   B5: "step", 
   B6: "caden", 
   paceLength: 1000, 
   notify: { 
     dist: { 
       value: 0, 
       notifications: [], 
     }, 
     step: { 
       value: 0, 
       notifications: [], 
     }, 
     time: { 
       value: 0, 
       notifications: [], 
     }, 
     HRM: { 
       min: 65, 
       max: 170, 
     } 
   }, 
 }, require("Storage").readJSON("run.json", 1) || {});

(https://github.com/thyttan/BangleApps/blob/karvonnen/apps/run/app.js)

The other stuff I should be able to sort out tomorrow.

Posted at 2023-02-20 by @halemmerich

Only if you give settings.notify.HRM to show(). I think HRM should not be under notify but directly under settings.

Posted at 2023-02-21 by @thyttan

Thanks for spotting that 😊😅

Posted at 2023-02-21 by @thyttan

• I think I've fixed most things regarding theming, but not a light background arc.
• I think the pulse number shouldn't jump around.
• moved HRM out of the notify key in settings defaults.

Posted at 2023-02-22 by @thyttan

• light background arc now in place.

Now I'm pretty confident with most things and I could do a PR to the main BangleApps repo. Ok with you, @FTeacher? :)

I might look into using eval as you suggested, @halemmerich. (If you don't feel particularly compelled to do it :p)

Posted at 2023-02-22 by Fteacher

Yeah sure, go ahead :).
I uploaded the app on my watch and did a quick test a few hours ago, it already looked like it works ! Really nice.

Posted at 2023-02-22 by @halemmerich

I can have a look at splitting the additional page out :) Since the code is already in it's own file it probably is relatively easy. I suspect the combined code is to heavy for Bangle 1, so some changes have to be made anyway to keep Run feasible for Bangle 1. It seems to be very tight on memory as @Humpelstilzchen can not run it now. This of course depends on other installed widgets/boot code using memory, so maybe it is still working now for others.
Will have a try this evening and do a pull on your repo if successful @thyttan.

Posted at 2023-02-22 by user140377

@halemmerich Please note I wasn't even able to run the unchanged run app on the Bangle.JS1. So I would not invest to much work on this, just remove Bangle.js1 from the supported list.

Posted at 2023-02-22 by @halemmerich

Just using Run on my Bangle 2 uses around 2000 blocks of the available 12000. Since Bangle 2 has 4 times the memory of the Bangle 1 I guessed that Run should still fit, if there is not to much other stuff running.

Posted at 2023-02-22 by @thyttan

I can have a look at splitting the additional page out :)

Thanks, please do :) I had a stab at it and it works, updated on my karvonnen branch. But adding logic for eval-ing additional extension screens and handling if karvonnen is not installed is not there yet.

I suspect the combined code is to heavy for Bangle 1, so some changes have to be made anyway to keep Run feasible for Bangle 1.

That would be ideal if possible then.

Posted at 2023-02-22 by @thyttan

I just opened a draft PR, so reviewing the code is a little easier now.

Posted at 2023-02-22 by @gfwilliams

edit: Sorry, I didn't see the whole second page of comments, so this is less useful now!

I'd say run.karvonnen.js or something like that would be a good bet.

The thing I'm thinking of is there's a file for working out sunset, and then it started being used in a few places, and we had multiple apps providing sunset.js, many of which were different - and obviously we want to avoid that.

If you though it might be used in other apps you could always add it to the modules folder?

Posted at 2023-02-22 by @gfwilliams

I just saw the PR come in: espruino/BangleApps#2591

I've got to say, I'm a little anxious about adding this to the default run app - I remember folks with Bangle.js 1 complaining that even the current app could run into RAM issues with some extra widgets installed - this would make it almost unusable?

The whole idea of me spending a bunch of time creating the exstats library was to try and make it easy for others to create new run apps with minimal code duplication, and to keep the standard run app as a very simple base that others could learn and build from.

While the Karvonnen stuff looks great, it more than doubles the code size of the run app (145 to ~400 lines?)

Maybe we should instead just rename it as a brand new app run-karvonnen or something?

Posted at 2023-02-22 by @thyttan

Maybe we should instead just rename it as a brand new app run-karvonnen or something?

Totally fine by me! Or would @halemmerich suggestion maybe be a good idea:

Maybe just give the run app a mechanism to eval additional pages which can be selected by swiping but are installed as separate apps. Just to keep run as slim as possible by default. (...)

?

Posted at 2023-02-22 by @gfwilliams

Maybe just give the run app a mechanism to eval additional pages which can be selected by swiping but are installed as separate apps. Just to keep run as slim as possible by default.

I missed this! It seems like a good idea, but it feels a bit like we're almost re-implementing 'fast load' all over again...

I'd rather not have a whole new app type that's a loadable fitness screen if it ends up only used by one app (run) and with only one screen (karvonnen). I know there are some apps (kitchen?) that have been made (by @hughb?) that had multiple screens loaded on demand, but I'm not sure if there would be any interest in splitting those screens out or how sensible it is.

Maybe exstats could be modified so it stores the current run status on exit, and then you could switch apps while running - which would be a huge benefit anyway. Then it'd be as easy as allowing run to just fast-load another app on swipe and it'd be super configurable? ... but then what the swipe did would need configuring which isn't quite as easy as having it work straight away.

It's a hard one... I feel like maybe a separate app that does it all (run-karvonnen / run+) is best for now, and then if we start to end up with a bunch of fitness apps/duplication we revisit it and see if there needs to be a whole new app type.

Posted at 2023-02-22 by @thyttan

Maybe exstats could be modified so it stores the current run status on exit, and then you could switch apps while running - which would be a huge benefit anyway.

Ooh, that could be cool indeed 😯

It's a hard one... I feel like maybe a separate app that does it all (run-karvonnen / run+) is best for now, and then if we start to end up with a bunch of fitness apps/duplication we revisit it and see if there needs to be a whole new app type.

Sounds sensible enough to me 🙂 I'll wait for @halemmerich to chime in before redoing the PR as a new app.

Posted at 2023-02-22 by @halemmerich

Then how about leaving it as is, renaming to Run+, specifying only Bangle 2 in metadata and just wait for somebody to implement additional screens there before thinking about how to split them out? That could also be a base to try out minimizing RAM usage by loading/unloading the screens inside the app to make it work on Bangle 1.
Getting exstats to store on exit is probably useful anyway, since not being able to switch apps on a longer activity like biking is a bit limiting currently.

Posted at 2023-02-22 by @gfwilliams

Then how about leaving it as is, renaming to Run+, specifying only Bangle 2 in metadata and just wait for somebody to implement additional screens there before thinking about how to split them out?

Yes, sounds great to me!

I'll see when I can get some time to tweak exstats

Posted at 2023-02-22 by @thyttan

Ok! I'll do some changes and then mark the PR as ready for review.

Posted at 2023-02-22 by HughB

I am looking forward to trying this out.

Posted at 2023-02-23 by @gfwilliams

Ok - it's merged in the dev app loader now.

I also made exstats save the state between runs of the app, so you can start a run, exit the app with a long press and then re-enter it and resume.

Posted at 2023-02-23 by @halemmerich

Had a run using the app and it works quite well. I have some minor nitpicks and a few ideas:

• 3 digit pulse overdraws on the ring on the right side, so the ring probably needs to be drawn again after the pulse has been updated
• The alert screen should show the pulse, that would make it easier to find a maximum without recording. The number on the other page is difficult to read going all out :)
• A lock indicator on the Karvonnen page would be nice
• Vibration on changing zones could be helpful
• Maybe find a way to switch page without unlocking? Since the accelerometer is always active maybe there could be a threshold where you could give the watch a hearty whack to switch while it is not triggered by running/biking?

Posted at 2023-02-23 by Fteacher

I like Halemmerich's suggestions, especially the vibration on changing zones.

1. If there's a vibration on zone change, maybe it should be handled in settings (like buzz on distance, on time, etc...)
2. About the bpm for the alert that's a good idea, so that people can adjust their max heart rate. About this topic, most physicians consider going 100% or close of your heart rate's max to be a threat for one's life. It's the kind of effort that can be sustained only for a few seconds and that is extremely demanding. Finding your max heart rate this way is not encouraged (yes I did anyway). We don't want to encourage people to trigger the alarm zone...
3. In the app download sections, in the readme sections, there should be a word about how to get minimum heart rate. It should be when you wake up before you made any move. That's where the heart rate is at its lowest. My min bpm is at 58 during the day, but drops down to 48 when I wake up, that makes a noticeable difference for the calculation of the Karvonnen zones.
4. I'm excited about trying this out :)) !!
5. I tried it. Looks nice ! But...
6. All the settings are ignored. Min and max hr are ignored, the number of boxes, and so on.
7. Because it's unconvenient to remember if we have to swipe right or left to get to the other screen, I think that any wipe action should bring the other part of the app.

Posted at 2023-02-24 by @thyttan

3 digit pulse overdraws on the ring on the right side, so the ring probably needs to be drawn again after the pulse has been updated

Fix in this PR

EDIT:

All the settings are ignored. Min and max hr are ignored, the number of boxes, and so on.

Fix for settings added to the PR.

Posted at 2023-02-25 by @thyttan

I also made exstats save the state between runs of the app, so you can start a run, exit the app with a long press and then re-enter it and resume.

Really cool, thanks!

Posted at 2023-02-25 by @thyttan

All the settings are ignored. Min and max hr are ignored, the number of boxes, and so on.

Fixed now, update on my app loader.

Posted at 2023-02-25 by user140377

I have finally read the wikipedia about this karvonen thing and now I'm an expert in it ;)

Well I have a question: It loos like the Karvonnen method is not limited to running. Wouldn't it make sense to move the karvonen file into a separate library-app, so it can also be used outside of "run", e.g. in "Cycling speed sensor" or even in a standalone app?

Posted at 2023-02-26 by Fteacher

hey @user140377 , yes Karvonnen works for all sports and maybe some cycling apps may get benefit from using this.
As the next gen of banglejs will be waterproof and will contain a much more accurate gps and HRM (we all have dreams), it will be the perfect companion of all triathletes and sportsmen. That's where the Karvonnen will really shine :).
On a more serious note, when I run with a Garmin watch and export the data (.fit) in GoldenCheetah (libre software to keep track of performances) , the time I've spent in each HR zone is automatically calculated, not with the .gpx of the banglejs.
I'm off for a test run+ ! Thanks for the fix Ganblejs !!

Posted at 2023-02-27 by Fteacher

Waow, it works great. It's reactive, looks nice and works as expected ! Thanks to all of you, you made my day and year, because I'll be using this app two to four times a week. I hope others will also get benefits out of it. I looked at the code, you did a great job at making this work efficiently. I can't decypher it all, but most of it makes sense, or at least I can guess what it means. It would have required a year of fiddling before I approach something that barely works.
I went for 1 hour run, and the battery handled it, but it may have a sligthly higher toll on the energy draw (compared to the run app).
I think anyone who tried run+ will agree: swiping between both parts of the app with a single direction swipe impacts negatively the UX.
What more ? Bucket list...
At the end of the race, I'm patient enough to go back home and check all the details, but it's only because I have no choice, otherwise, I'd be delighted to see the run stats, namely the percentage of time spent in each Karvonnen zone, average HR, distance, time, average pace, ...

Posted at 2023-06-05 by @thyttan

I just realized we don't have any info regarding the karvonen screen in the README.md file of runplus. Could you maybe put something in there @FTeacher?

Posted at 2023-07-13 by @thyttan

There are some hr zone stuff implemented in Gadgetbridge for adding to "Activity Tracks". So if we logged the current karvonen zone in the recorder log, maybe we could integrate that into the info displayed in Gadgetbridge.

Here is the code in Gadgetbridge

Here I'm working on adding Activity Track support for Bangle.js in Gadgetbridge

EDIT: As per espruino/BangleApps#3068 (comment), it's probably better to have gadgetbridge calculate hr zones from the heart rate data when parsing. The info is there so it's unnecessary to add another field with calculations.

Posted at 2023-11-02 by @thyttan

I realized that instead of using setInterval on the karvonen screen we probably want to act on the Bangle.HRM event. I'll refactor sometime soon.