You are reading a single comment by @crazysaem and its replies. Click here to read the full conversation.
  • Thank you for the code! I put both of your code in a draft PR (see link below), please let me know what you think. I currently don't have too much time so I hope I didn't miss anything. (Screenshots still need to be updated in the PR)
    I also credited both of you in the README, let me know if that is alright for you.

    @HughB

    The pattern attribute looks great, I put your code into the next PR with one small change. Instead of conditionality setting the pattern based on the dark flag I'm using the fg and bg colors in the palette. That should hopefully also work for custom themes, although I haven't checked.

    palette: new Uint16Array([g.theme.fg, g.theme.bg], 0, 1),
    

    @PaddeK

    Thanks for the improvement, I especially like the position.b flag which allows us to get rid of the artificial delay of 500ms, awesome!
    I only did a small tweak, namely changing all let's and consts to vars. I did this because the espruino interpreter will treat those as vars anyway, and I'd rather make it explicit, since they do behave differently. ( See https://www.espruino.com/Features#es6 )

    https://github.com/espruino/BangleApps/pull/1158

About

Avatar for crazysaem @crazysaem started