Number.toFixed() not rounding per specification

You are reading a single comment by @Robin and its replies. Click here to read the full conversation.

•

Robin
Sun 2019.08.25

Links to areas of source that appear to be the entry points that will need a looksy:

Definition

https://www.espruino.com/Reference#l_Number_toFixed

GitHub source file for toFixed()

https://github.com/espruino/Espruino/blob/master/src/jswrap_number.c#L120
```
JsVar *jswrap_number_toFixed(JsVar *parent, int decimals) {
  if (decimals<0) decimals=0;
  if (decimals>20) decimals=20;
  char buf[JS_NUMBER_BUFFER_SIZE];
  ftoa_bounded_extra(jsvGetFloat(parent), buf, sizeof(buf), 10, decimals);
  return jsvNewFromString(buf);
}
```
JS_NUMBER_BUFFER_SIZE is suspect, but I'm not able to locate where that constant is defined

ftoa_bounded_extra

https://github.com/espruino/Espruino/blob/master
https://github.com/espruino/Espruino/blob/master/src/jsutils.c
https://github.com/espruino/Espruino/blob/master/src/jsutils.c#L614
```
void ftoa_bounded_extra(JsVarFloat val,char *str, size_t len, int radix, int fractionalDigits) {

// possible areas that end of array may be encountered
```
jsvGetFloat

https://github.com/espruino/Espruino/blob/master
https://github.com/espruino/Espruino/blob/master/src/jsvar.c#L1867
```
JsVarFloat jsvGetFloat(const JsVar *v) {

// too many lines and entry points to list here
```

About

Avatar for Robin @Robin started