You are reading a single comment by @dklinkman and its replies.
Click here to read the full conversation.
Espruino is a JavaScript interpreter for low-power Microcontrollers. This site is both a support community for Espruino and a place to share what you are working on.
@dklinkman
@Gordon should I just send you the file? I think a pull request has to include all the changes for a commit level. Or so I think, I've actually never done a PR. I'm happy to attempt a PR on the full commit. 4 files I think.
The changes to connect.js are more extensive than discovery.js. I don't know what you mean by 'UART specific", except that it is in fact the UART service and characteristic that the code is retrieving. For some reason job.device.discoverAllServicesAndCharactÂeristics(...) in the original code was not returning for me, so the timeout would always occur, or at least 95% of the time. So I changed the logic to use discoverServices() and discoverCharacteristics() which worked very well. That's the gist of the changes there except I also added a recursive function to write additional chunks of data when the data was more than 20 bytes. Works well! Oh and I fixed the /ble/read topic code which was crashing due to a missing parameter.