You are reading a single comment by @Gordon and its replies. Click here to read the full conversation.
  • Yes, that's all worked great. Got the pull request and I'll merge it in.

    Especially for small changes that can go in and don't affect the building of everything else, that's the best way to handle them. You want any pull request you send to be self-contained (in that it isn't part of a 'work in progress' though).

    So for bigger changes you might want to do a bit of work, with maybe several commits, and then only issue a pull request when it's done.

    As I understand it, with Git if you issue a pull request from a branch (eg. master) then any changes you push to GitHub after you've made the PR will update the PR. That may not be what you want, if you're working on stuff continually, so for bigger changes you may well want to create a branch locally, work on that, and then submit a pull request for just that branch.

    Just wanted to check though, I notice in your diff you change:

    [#if](http://forum.espruino.com/search/?­q=%23if) __WORDSIZE == 64
    

    to

    [#if](http://forum.espruino.com/search/?­q=%23if) defined(__WORDSIZE) &&__WORDSIZE == 64
    

    I don't think that actually does anything apart from complicate the code though - or did it actually cause you compile problems? If __WORDSIZE isn't defined, then it's not equal to 64 so the statement still works as expected?

About

Avatar for Gordon @Gordon started