You are reading a single comment by @MichaelPralow and its replies. Click here to read the full conversation.
  • Thanks - looks good! Shame about the constants though - must have
    taken you ages to inline them, and it's something that the minifier
    would have done for you just by changing prototype.C to var C :)

    Javascript IDE Atom to the rescue :-)
    in the end private constants wouldn't help module users, e.g. for using display.sendCommand(...), but the documentation helps module maintainers (well i hope so)

    Super minor, but it looks like bitMaskArray and pixelBitPosArray are
    no longer needed now?

    good catch, i already changed that locally

    A pull request via Espruino's GitHub is still definitely the preferred
    way

    ok, but it is definitely worthwile to think about NPM, at least for maintaining a module (test, versioning, own github repo, ...)

About